Open
Conversation
…n after abstract deadline
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Senior Area Chair (SAC) support to the “new venue UI” / conference review workflow by extending the venue request form, wiring SAC roles into deployment + matching pipelines, and expanding test coverage (including a new end-to-end-ish ICLR template workflow test).
Changes:
- Extend conference venue request form to include
senior_area_chairs_supportandsenior_area_chairs_name, plus validation that SACs require ACs. - Update workflow deployment, matching/affinity score computation, invitation templates, and venue model logic to handle SAC committees (bidding, readers/invitees, matching vs alternate committee).
- Update and add tests to include SAC fields and validate SAC-specific behaviors in template workflows.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_venue_restriction.py | Adds senior_area_chairs_name to venue setup payload used by restriction tests. |
| tests/test_tasks.py | Adds senior_area_chairs_name to venue setup payload used by task tests. |
| tests/test_reviewers_only.py | Adds senior_area_chairs_name to venue setup payload; includes a formatting-only adjustment to an invitation edit call. |
| tests/test_registration_step.py | Adds senior_area_chairs_name to venue setup payload used by registration-step tests. |
| tests/test_reduced_load_new_ui.py | Adds senior_area_chairs_name to venue setup payload used by reduced-load tests. |
| tests/test_iclr_conference_with_templates.py | New comprehensive template workflow test covering SAC recruitment, bidding, matching/deployment, and stage readers/invitees. |
| tests/test_change_venue_email.py | Adds senior_area_chairs_name to venue setup payload used by venue-email tests. |
| tests/test_assign_committee_open_deadline.py | Adds senior_area_chairs_name to venue setup payload used by committee assignment deadline tests. |
| tests/test_acs_and_reviewers.py | Adds senior_area_chairs_name to venue setup payload used by AC/reviewer workflow tests. |
| tests/test_abstract_deadline.py | Adds senior_area_chairs_name to venue setup payload used by abstract-deadline tests. |
| openreview/workflows/workflows.py | Extends the conference request form schema with SAC support/name fields and shifts subsequent field ordering. |
| openreview/workflows/workflow_process/request_form_preprocess.py | Validates that SAC support cannot be enabled unless AC support is enabled. |
| openreview/workflows/workflow_process/edit_recommendation_field_name_process.py | Propagates edited meta-review form content into the SAC meta-review revision invitation when SACs exist. |
| openreview/workflows/workflow_process/conference_review_workflow_deployment.py | Adds SAC bid stage creation and includes SACs in comment/rebuttal readers/invitees; also sets up expertise selection stage and additional readers for note releases. |
| openreview/workflows/workflow_process/committee_group_template_process.py | Passes committee_pretty_name through committee invited/declined group template processes for better descriptions. |
| openreview/workflows/templates.py | Adds committee_pretty_name to committee invited/declined group templates and uses it in group descriptions. |
| openreview/workflows/process/compute_affinity_scores_process.py | Adds optional alternate committee support for affinity computation; fixes typo and returns early when groups are empty. |
| openreview/workflows/edit_invitations.py | Adjusts license edit schema and the template placeholder path for license enum propagation. |
| openreview/venue/venue.py | Gates SAC enablement on senior_area_chairs_support, adds SAC naming helper, and wires SAC assignment + matching setup. |
| openreview/venue/matching.py | Supports “SAC-to-alternate-committee” affinity edges (profile-to-profile) and skips conflict invitation creation for SAC matching mode. |
| openreview/venue/invitation.py | Renames a local variable for clarity and adds template-workflow SAC meta-review revision date editing support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
melisabok
reviewed
Apr 22, 2026
| 'submission_deadline': { 'value': openreview.tools.datetime_millis(due_date) }, | ||
| 'reviewers_name': { 'value': 'Program_Committee' }, | ||
| 'area_chairs_name': { 'value': 'Area_Chairs' }, | ||
| 'senior_area_chair_role_name': { 'value': 'Senior_Area_Chairs' }, |
Member
There was a problem hiding this comment.
if the venue doesn't use SAC, why do we need to set a value for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for SACs in the New Venue UI. Major changes include changes to matching invitations and affinity score computation.